Conversation
Contributor
Author
|
I don't know what is up with GitHub. If you check Travis you'll see the PR built successfully. It's pointing to one I canceled because I knew it would be run again when I opened the PR. |
Owner
|
Looks good. Im going to merge and bump the minor since this is a breaking change for those folks using 0.0.8 and assuming edge will be marked as msie |
gabceb
added a commit
that referenced
this pull request
Nov 23, 2015
Support Microsoft Edge (Windows and Windows Phone)
Owner
|
Done. Thanks again @le717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63. All relevant keys are named
msedge. Also swap the running order of the IE 11 tests (desktop, then Windows Phone).As I suspected, we already correctly detected Edge but stuffed it under IE (as version 12). With minor refactoring I was able to correctly expose Edge.
FYI on the Edge versioning, see this post on the MS Edge dev blog.